4004: Can't create New Review Request

merlin_zaraza

What version are you running?

1.6.12

What's the URL of the page containing the problem?

http://coderev.emmlabs.ibm.com/r/new/

What steps will reproduce the problem?

  1. Click "New Review Request"
  2. Choose SVN
  3. Enter base directory from "svn info" command output (e.g. /path1/path2)
  4. Choose patch file

What is the expected output? What do you see instead?

Expected result: Review Request created.
Actual result: Review Request in't created. Error appeared: The file '/path1/path2/src/main/java/com/somecompany/AbstractInputFile.java' could not be found in the repository.

What operating system are you using? What browser?

Ubuntu 14.04 x64, Chrome 46.0.2490.80, SVN 1.8.8 (r1568071)

Please provide any additional information below.

Sure, there are no such file '/path1/path2/src/main/java/com/somecompany/AbstractInputFile.java' in repository, because it's NEW file.

#1 merlin_zaraza

Problem is in patch file generated.
For new files added patch code is:
--- src/main/java/com/somecompany/AbstractInputFile.java (revision )
+++ src/main/java/com/somecompany/AbstractInputFile.java (revision )

With svn --patch-compatible option patch code is:
--- src/main/java/com/somecompany/AbstractInputFile.java (revision 0)
+++ src/main/java/com/somecompany/AbstractInputFile.java (working copy)

chipx86
#2 chipx86

Review Board 1.6.x is very old and no longer supported. We've since fixed this. If you can upgrade to a newer release, you should find that these patches work as expected.

david
#3 david
  • -New
    +Fixed