3994: No notification Email is sent when commenting on a review request using chrome
- Fixed
- Review Board
myusuf | |
What version are you running?
2.0.1
What's the URL of the page containing the problem?
review/board/url/r/56
or any issueWhat steps will reproduce the problem?
- write a comment on a review request from chrome browser.
What is the expected output? What do you see instead?
Expected: Receving E-mail containing the comments.
Waht Happen : sometimes No E-mail is sent although it is published and shown in the review request for all userswhen going to the logs we found the following log error :
- Error sending e-mail notification with subject 'Re: Review Request 22: Summary of ticket ' on behalf of '"User1" user1Email@domain' to '"User2" User2Email@domain,"user1" User1Email@domain: 'ascii' codec can't encode characters in position 268-273: ordinal not in range(128)
Traceback (most recent call last):
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-2.0.1-py2.6.egg/reviewboard/notifications/email.py", line 278, in send_review_mail
message.send()
File "/usr/local/lib/python2.6/dist-packages/Django-1.6.5-py2.6.egg/django/core/mail/message.py", line 274, in send
return self.get_connection(fail_silently).send_messages([self])
File "/usr/local/lib/python2.6/dist-packages/Django-1.6.5-py2.6.egg/django/core/mail/backends/smtp.py", line 94, in send_messages
sent = self._send(message)
File "/usr/local/lib/python2.6/dist-packages/Django-1.6.5-py2.6.egg/django/core/mail/backends/smtp.py", line 110, in _send
self.connection.sendmail(from_email, recipients, message.as_bytes())
File "/usr/local/lib/python2.6/dist-packages/Django-1.6.5-py2.6.egg/django/core/mail/message.py", line 135, in as_string
g.flatten(self, unixfrom=unixfrom)
File "/usr/lib/python2.6/email/generator.py", line 84, in flatten
self._write(msg)
File "/usr/lib/python2.6/email/generator.py", line 109, in _write
self._dispatch(msg)
File "/usr/lib/python2.6/email/generator.py", line 135, in _dispatch
meth(msg)
File "/usr/lib/python2.6/email/generator.py", line 201, in _handle_multipart
g.flatten(part, unixfrom=False)
File "/usr/lib/python2.6/email/generator.py", line 84, in flatten
self._write(msg)
File "/usr/lib/python2.6/email/generator.py", line 109, in _write
self._dispatch(msg)
File "/usr/lib/python2.6/email/generator.py", line 135, in _dispatch
meth(msg)
File "/usr/lib/python2.6/email/generator.py", line 178, in _handle_text
self._fp.write(payload)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 268-273: ordinal not in range(128
Note: That Error happens when using chrome only but not firefox.
What operating system are you using? What browser?
- Linux, Chrome
- Windows, chrome