3953: no Email on ship it action

Guillaume
What version are you running?
Review Board 2.0.19

What's the URL of the page containing the problem?
http://172.16.13.193/reviewboard-lab/r/41/

What steps will reproduce the problem?
1. Create an new review request

2. Ship It 

Upon ship it, an email was sent in old version but not with this new version.
It's works when using create or submit action

in Server Log (I have mask email address by ****)
	
18:08:20	ERROR

 - Error sending e-mail notification with subject 'Re: Review Request 42: Task - 105402: test21 - rer' on behalf of 'at**** <at*****@***.**>' to 'at**** <at****@***.**>,gp**** <gp*****@***.**>'
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/notifications/email.py", line 632, in send_review_mail
    message.send()
  File "/usr/lib/python2.6/site-packages/Django-1.6.11-py2.6.egg/django/core/mail/message.py", line 276, in send
    return self.get_connection(fail_silently).send_messages([self])
  File "/usr/lib/python2.6/site-packages/Django-1.6.11-py2.6.egg/django/core/mail/backends/smtp.py", line 94, in send_messages
    sent = self._send(message)
  File "/usr/lib/python2.6/site-packages/Django-1.6.11-py2.6.egg/django/core/mail/backends/smtp.py", line 110, in _send
    self.connection.sendmail(from_email, recipients, message.as_bytes())
  File "/usr/lib/python2.6/site-packages/Django-1.6.11-py2.6.egg/django/core/mail/message.py", line 138, in as_string
    return fp.getvalue()
  File "/usr/lib64/python2.6/StringIO.py", line 270, in getvalue
    self.buf += ''.join(self.buflist)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 400: ordinal not in range(128)


What operating system are you using? What browser?
centos 2.6.32-504.23.4.el6.x86_64
Chrome Version 44.0.2403.157 m
#1 shu****@gmai***** (Google Code) (Is this you? Claim this profile.)
Same problem here. Not just for "ship it" emails, but any emails that contain Chinese characters.
brennie
#2 brennie
Can you try this on the latest release-2.0.x? I believe this was fixed in commit a22600574e26571f0ee31eba46322e73995531cd.
david
#3 david
  • -New
    +NeedInfo
Guillaume
#4 Guillaume

This bug was fixed in new release ReviewBoard-2.0.20
Thx

david
#5 david

Thanks!

  • -NeedInfo
    +Fixed