jameslin

388: Button to delete comments only works after immediately saving a comment

jameslin
chipx86
 chipx86
Dec. 28, 2008 
What steps will reproduce the problem?
1. Add a comment to a diff.
2. Save the comment.
3. Close the dialog.
4. Click on the comment to show it.
5. Try to delete the comment.

What is the expected output? What do you see instead?
The "Delete Comment" button is disabled.  In order to delete the comment,
I need to edit the comment and click "Save Comment" first.


What operating system are you using? What browser?
Firefox 2.0.0.8 on Windows XP SP2
chipx86
#1 chipx86 
Should probably get this for 1.0.
  • +Milestone-Release1.0
    +Component-DiffViewer
chipx86
#2 chipx86 
I can't actually reproduce this anymore. It could be that this was fixed since the
last server update as part of another change. The code looks correct...

Closing for now. If it continues to happen after the next server upgrade, we should
look into this further. It could be that something else entirely is happening that's
causing this button to be deleted.
  • +Fixed
  • +chipx86
jameslin
#3 jameslin 
Hey, this is still happening.
chipx86
#4 chipx86 
Okay. This will be fixed in the UI rewrite then. Sorry :/
  • -Fixed
    +Confirmed
jameslin
#5 jameslin 
Oh, it works if I click on the comment marker in the left margin.  If I click on the
line itself, it still brings up the comment dialog, but the buttons are disabled.
(Also see issue 720.)
chipx86
#6 chipx86 
Fixed in r1644.
  • -Confirmed
    +Fixed