3874: Upload diff error 207, but the file exists

dnephin-t*********@yelp**** (Google Code) (Is this you? Claim this profile.) 
What version are you running?

2.0.12


What's the URL of the page containing the problem?

/api/json/reviewrequests/{review_request_id}/diff/new/



What steps will reproduce the problem?
1. Create a git repo with some files
2. chmod +x some file, git add, git commit that file
3. git rm the file, and commit
4. post a new review using `rbt post ...`


What is the expected output? What do you see instead?

I expected my review to be posted with a diff. Instead I received 


ERROR: Error uploading diff 

The file was not found in the repository. (HTTP 400, API Error 207)



What operating system are you using? What browser?

N/A, issue is with the API


Please provide any additional information below.


`rbt` wasn't properly returning the file from the response, after hacking it up to print the full response I saw the error was caused by a file that I had run `chmod +x` on in one commit, and  `git rm` in the next.

I then rebased out the `chmod +x` commit, and the upload diff succeeded.
brennie
#1 brennie 
The URL you indicated isn't one that Review Board uses. Did you mean:

api/review-requests/{review_request_id}/diffs/

?
  • +NeedInfo
chipx86
#2 chipx86 
That API was deprecated in 1.5 and we stopped shipping it in 1.6. There's no possibility of using that API in 2.0.12. Can you double-check the version and the URL you're using?
chipx86
#3 chipx86 
Also, we'll need the full RBTools output with --debug.
#4 dnephin-t*********@yelp**** (Google Code) (Is this you? Claim this profile.) 
Ah, I think I was looking at an old version of the API docs (1.5).  I was using the `rbt` tool, so I didn't curl the url myself.

I think it would be

POST /api/review-requests/{review_request_id}/diffs/

yes
#5 dnephin-t*********@yelp**** (Google Code) (Is this you? Claim this profile.) 
Full debug output of `rbt`: http://pastebin.com/7eAG5SrB

The diff for that file looks something like this http://pastebin.com/MDTQpvMY
david
#6 david
  • -NeedInfo
    +Fixed