3846: Request for adding a new field to review board called "Impact to code coverage"

adog****@gmai***** (Google Code) (Is this you? Claim this profile.)
April 15, 2015 
What version are you running?
2.0.10

What's the URL of the page this enhancement relates to, if any?
https://reviewboard.eng.vmware.com

Describe the enhancement and the motivation for it.
Request is for adding a new field called "Impact to code coverage" which is a text field meant for users to provide quantitative as well as qualitative data. The intent is to promote engineering best practices within the team, especially to raise awareness and to track code coverage.

What operating system are you using? What browser?


Please provide any additional information below.
david
#1 david 
This request is pretty specific to one use case, and as such is something that we will not be adding to the core product (if we added every field that everybody wanted then we'd end up with something that looked like JIRA). Extensions can add new fields relatively easily, so I suggest pursuing that route.
  • +WontFix
#2 adog****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Thanks for the response. Could you please provide some more info on the
'Extensions' that you are recommending for us to use?
david
#3 david 
Review Board has a powerful extension framework that allows third parties to add functionality:

https://www.reviewboard.org/docs/manual/2.0/extending/

In particular, additional fields can be added to the review request via this hook:

https://www.reviewboard.org/docs/manual/2.0/extending/extensions/hooks/review-request-fields-hook/
#4 adog****@gmai***** (Google Code) (Is this you? Claim this profile.) 
These are good references. A few questions, would appreciate your response.
1. Would the extension only apply to certain reviews?  Or certain groups?  Or the whole reviewboard server? 

2. Where would it be installed? The eng reviewboard server? Or are you saying we get our own reviewboard server and extend that?  Whats the rationale behind denying addition of new field but encourage writing an extension to do the same thing.
david
#5 david 
1. So extensions typically apply to the entire Review Board server. It's possible within a field definition to make it show up for only certain conditions, depending on how it's written.

2. This bug tracker is about the upstream, open-source Review Board project. The particular server(s) running inside VMware aren't under our control.