3822: Review against self listed in incoming & outgoing
- NotABug
- Review Board
vlo****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
March 25, 2015 |
What version are you running? 2.0.13 What's the URL of the page containing the problem? dashboard/?view=outgoing dashboard/?view=incoming What steps will reproduce the problem? 1. Set myself as the sole reviewer for a feature What is the expected output? What do you see instead? I was hoping that the issue would only be listed in my outgoing. Instead it appears in both. Please provide any additional information below. I can see the perspective from both sides but it feels like having it be listed only in outgoing would be the slightly less surprising behaviour. Not sure if this is intentional or just an oversight where self isn't filtered out of reviewers for incoming issues.
This is the expected behavior. Adding an exception just for this case would, I think, be a little inconsistent (you also see your review requests assigned to groups you're a member of in your "incoming" list) and would further complicate some already very complicated database queries.
-
+ NotABug
Actually the group case indicates to me even more that it would be expected for those to be omitted. Conceptually, "incoming" means "review action required" whereas "outgoing" means "pending review action". I guess from my perspective, the "not a bug" would be reserved for "this is intentionally UI we've explored & here is the reason we want this", not "the implementation would be complex". I'm assuming you're saying that it's the former & the latter is the cherry on top. Can you clarify the reasons why the current behaviour is expected to be the less confusing UI design?