3795: Redirected back to page 1 of diff when clicking a file link in a multi-page diff
- Fixed
- Review Board
| gmyers | |
| April 8, 2015 |
What version are you running? 2.0.13 or 2.5 alpha 0 (dev) What's the URL of the page containing the problem? Any review request where the diff has been split across multiple pages. For example: https://reviews.reviewboard.org/r/6925/diff/1/?page=2 What steps will reproduce the problem? 1. Navigate to https://reviews.reviewboard.org/r/6925/ 2. Click View Diff 3. Click 2 at the bottom of the File Index to advance to page 2 of the review request. 4. Click the link for any file in the File Index. For instance reviewboard/diffviewer/testdata/new_src/README which is near the middle of the list. Hovering over this link shows https://reviews.reviewboard.org/r/6925/diff/1/?page=2#29 as the target 5. We advance momentarily to the README file as expected and then are "redirected" back page 1 of the review request. What is the expected output? What do you see instead? Expect to advance to the selected file and stay there. Always seem to be redirected back to the first page. Since this is a dynamic issue I don't know how to capture it via a screen shot, but I can attempt to capture a video if that would be informative. What operating system are you using? What browser? Windows Firefox 36.0 Please provide any additional information below. This may be a Firefox specific issue as I can not replicate it in IE. The review request that I used as an example has a bunch of deleted files, but I don't think that has anything to do with this. I have been able to repeat this on multiple review requests on multiple different RB severs. The only commonality is that I'm always using Firefox.
We are also experiencing this same issue. It doesn’t matter how long you wait either. Once the page is loaded, you click the file name and it refreshes back to the first page. Also, you will see this issue if you scroll the page and click a header instead. We have this issue with Firefox and Chrome. I patched to 2.0.14 and started experiencing this issue with Internet Explorer. Since updating to 2.0.15, I can no longer replicate the issue in Internet Explorer. Trying to view my logs but the web page keeps closing. I will try again later. Please let me know if I can help in any way.
Just as an update to my last post, there are no errors in the server logs. I am using utf8_unicode_ci for the table collation in my MySQL database. All of the tables are using InnoDB for the engine. I tried upgrading Haystack to 2.3.1. The same error exists. I removed all Reviewboard installs under dist-packages, removed all Django related items, and then re-installed ReviewBoard. The same error exists (although the installation runs a lot faster).
I'm running 2.0.15 . Is there something I can do manually to get the bug fixed?
As a follow-up I restored my Test Box back from a 2.0.12 backup and the problem is not there. I ran: easy_install -U reviewboard==2.0.14 rb-site upgrade /var/www/reviews and the problem returned. Please let me know if you need a new issue opened or if there is anything else I can do.
Oh, my bad, I looked at the wrong bug fix. This was fixed in git on release-2.0.x (937e172) and will ship in 2.0.16
Thank you for the clarification. I look forward to the .16 release. We appreciate you guys.