My first time using reviewboard today, I used a process very similar to
vmware's current process of running perforce diffhtml and sending out a url
to reviewers. I:
- created the review using post-review
- sent this url to some colleagues who added inline review comments
- when I saw the comments, I changed my code and re-ran post-review
When I ran post-review the second time, it overwrote the original diff,
which is fine, but it didn't keep any of the comments!
The problem is that I didn't 'publish' the review, so it had not yet been
saved permanently or given a version number. Since it was in a draft state,
the second run of post-review just overwrite the diff and the comments as
well, which were stored with it.
One possibility would be to make it impossible to comment on an unpublished
review.
This is a very nice tool. Thanks and keep up the good work.
