376: Enhancement: provide developer with more control over when e-mail messages are sent
- Duplicate
- Review Board
| com-g*****@tan-far******* (Google Code) (Is this you? Claim this profile.) | |
| Jan. 22, 2008 |
Reviewboard tends to send out too many messages. For example, if one uploads a new diff to an existing review and then comments on reviews provided by another user, one has to send out two e-mail messages, which is problematic if the review messages go to a large number of people. Also, it should be possible to upload a new diff without publishing the review again (is it?) Also, I've experienced the following: for an already sent out review, if I add another reviewer, a new message is sent out before I have the change to upload a new diff or change the summary. It should also be possible to delete a diff, say, one uploaded by accident.
It's best not to publish diffs that you're not okay with. There's little point in being able to delete them, because the idea is that for better or worse, this is the history of your changes. Maybe we can add a feature for that down the road someday. However, you should file that as a separate request. The main feature request here, about the e-mails, is a dup of bug #183.
-
+ Duplicate
Agreed. But I am not referring to diffs that have been published. I am referring to diffs that you attach to the review and then realize you forgot to make one further change, in which case, you'd like to replace the current diff with one that includes the change before publishing it.
Ah, well you're in luck then. As long as you don't publish the diff, the changes you make don't stick. So you can upload 10 diffs before publishing and only the last one will be saved.