3742: File missing in View Diff list

ricktr******@gmai***** (Google Code) (Is this you? Claim this profile.)
May 17, 2015
What version are you running?
1.7.4

What's the URL of the page containing the problem?
Any review.

What steps will reproduce the problem?
1. Create review with Diff file listed below.  It's a simple whitespace change.
2. View the review and go to "View Diff"


What is the expected output? What do you see instead?
Expect that the file contained in the diff will be listed.  Instead, no file is listed.


What operating system are you using? What browser?
Linux RedHat, Chrome

Please provide any additional information below.

Here's the diff that was used to reproduce this problem.  In this case, the diff contains a simple whitespace change within and XML type comment.
I've checked that if the whitespace change is outside the XML comment, the file is properly listed in RB.
I've checked that if the file contains other changes (white-space or not) in addition to this change the file is also properly listed in RB.

<BEGIN DIFF>
Index: ./v1_0_0/xmlim/behavior/serviceSas.xml
===================================================================
RCS file: nms_nodes/sros/7210m/v1_0_0/xmlim/behavior/Attic/serviceSas.xml,v
retrieving revision 1.6.80.1
diff -u -r1.6.80.1 serviceSas.xml
--- ./v1_0_0/xmlim/behavior/serviceSas.xml	27 Jan 2015 19:17:01 -0000	1.6.80.1
+++ ./v1_0_0/xmlim/behavior/serviceSas.xml	28 Jan 2015 16:23:38 -0000
@@ -32,7 +32,7 @@
                             <validation errorKey="sas_cpeping_interval_controlplane">
                                 <!--
                                 throw the error  if
-                                  ! ( !controlplane || (controlplane&& pcaketInterval>4) )
+                                   ! ( !controlplane || (controlplane&& pcaketInterval>4) )
                                 -->
                                 <or>
                                     <equality name="sendViaControlPlane" value="false"/>
<END DIFF>
david
#1 david
What version control system? (looks like CVS?). How did you upload your change? What is the state of the "whitespace changes" toggle (at the bottom of the tan box that has all the review request details)?
  • +NeedInfo
#2 ricktr******@gmai***** (Google Code) (Is this you? Claim this profile.)
What version control system?:  CVS v1.11.23

How did you upload your change?:  New Review Request --> Upload file --> Create Review Request

What is the state of the "whitespaces changes" toggle?:  Toggling either "Hide Extra Whitespace" or "Hide Whitespace changes" has no effect.  File remains unlisted in the file list.
david
#3 david
This should definitely work in the 2.0.x series. 1.7.5 is quite old at this point.
  • -NeedInfo
    +Fixed