373: Base path being duplicated when uploading a patch

russell*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 22, 2008 
What's the URL of the page containing the problem?
It's not currently publicly accessible, but if it comes down to it, I could
make it happen.


What steps will reproduce the problem?
1. New Review Request
2. Set Repository to Asterisk
3. Set Base path to "trunk"
4. Select a patch to upload, and click Create Review Request.

The Asterisk repository is configured as "http://svn.digium.com/svn/asterisk/".


What is the expected output? What do you see instead?

I would expect the review request to be successfully created.  :)

Instead, I get a message box that pops up with this svn error:

PROPFIND request failed on
'/svn/asterisk/!svn/bc/99425/trunk/trunk/channels/vgrabbers.c'
'/svn/asterisk/!svn/bc/99425/trunk/trunk/channels/vgrabbers.c' path not found


What operating system are you using? What browser?

Reviewboard is running on Debian Etch.  The browser is firefox 2.0.


Please provide any additional information below.

This is a fresh install of reviewboard - svn trunk revision 1134.  django
trunk rev 7025.
#1 russell*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Odd.  I got it working.  It worked after I removed the first section of the diff,
that didn't really have any real changes in it.  I have attached the diff that caused
the problem for me.

As far as I'm concerned, this can be closed ...
  • +
    hmmm.diff 
    Index: vgrabbers.c
    ===================================================================
    --- vgrabbers.c	(.../trunk/channels/vgrabbers.c)	(revision 99463)
    +++ vgrabbers.c	(.../team/murf/bug11210/channels/vgrabbers.c)	(revision 99463)
    @@ -45,7 +45,7 @@
      */
     
     #include "asterisk.h"
    -ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
    +ASTERISK_FILE_VERSION(__FILE__, "$Revision$") 
     #include <sys/ioctl.h>
     #include "asterisk/file.h"
     #include "asterisk/utils.h"	/* ast_calloc */
chipx86
#2 chipx86 
Might be due to either the base path or something funky with the relative paths in
the diff. We'll close it though.
  • +NotABug
#3 russell*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
For what it's work, I did determine that the root cause was the relative paths in
parenthesis in the patch.  When I made a patch that didn't include that sillyness, it
works just great.

Thanks a lot, this app rocks.