3659: RBTools 0.6.2 not able to differentiate the binary content

shahgu******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
 david 
Hi,

I am using RBTools 0.6.2, it is not able to differentiate binary changes.
If I have the changes for keystore (.jks) file, it is not able to recognize the changes. Though there are changes, it says :

ERROR: There don't seem to be any diffs!

Am using command "rbt post changelist#"

My friend is using the earlier version of RBTools and he is successfully able to post the changes.

So this is a bug specific to this version.

Please let me know.

Thanks
david
#1 david 
I'm confused. Is .jks a text file that's being misinterpreted as binary? We've never been able to post changes to binary files.
david
#2 david
  • +NeedInfo
#3 marc.*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Yes a jks file is binary.  using an older version of rbt that supports post-review the review is still posted even when the only change is a binary file.  It seems with the new version the review is not posted because it can't determine any diffs
david
#4 david 
I don't see how this is a bug. You want a review request with no diffs?
#5 shahgu******@gmai***** (Google Code) (Is this you? Claim this profile.) 
We want review request with diffs, using RBTools 0.6.2.
david
#6 david 
I *really* don't understand what you mean. We've never done diffs of binary files. What behavior are you seeing with the older version (by which I mean what shows up in the "View diff" page?)
#7 marc.*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
When I do a review (using post-review) that contains only a single binary file the review is created and when looking at review board it says that one file has changed.  When you go to view the diff for that file it states "This is a binary file. The content cannot be displayed."

The main point is that when a review is created that includes a binary file it at least shows up as a file that has changed.  Using the newest version when you try and post a review that only contains binary file it errors out with "ERROR: There don't seem to be any diffs!".

Does this make sense?
david
#8 david 
OK, I think I understand. What version control system? Perforce?
#9 shahgu******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Yes Perforce.
#10 shahgu******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Any update on this ?
david
#11 david 
This is something that we'll fix eventually, but it's pretty low priority.
  • -NeedInfo
    +Confirmed
  • -Priority-Medium
    +Priority-Low
    +Component-RBTools
    +Project-RBTools
david
#12 david
  • +EasyFix
david
#13 david
  • -reviewboard
    +rbtools
  • -Project:RBTools
#14 Ann_wu 
rbt post -I [file]

Where is [file] go???

Where do [file] put in reviewboard server???

Thanks.
david
#15 david
  • -Confirmed
    +PendingReview
  • +david
david
#16 david 
Fixed in RBTools release-1.0.x (c09cb82). This will ship in RBTools 1.0.2. Thanks!
  • -PendingReview
    +Fixed