3657: Clicking OK on draft reply to body_top or body_bottom that is blank deletes entire review draft

thom.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 11, 2014
What version are you running?

2.0.11


What's the URL of the page containing the problem?

/r/#####

What steps will reproduce the problem?
1. Create a Review Request Lets use http://demo.reviewboard.org/r/2/ as an example. Publish it.
2. Post a Review to the request that has a body_top, and several diff comments, and a body bottom. For example:  http://demo.reviewboard.org/r/2/#review221 .  Publish it.
3. Create a draft to this review:
  3a. Add a comment to the header, enter some text, click ok.
  3b. Add a comment to the file, enter some text, click ok.
  3c. Add a comment to the footer.  Don't enter any text, click OK with it blank.

What is the expected output? What do you see instead?

Actual:  The comment for the header and file is deleted and lost for good.


Expected: The draft is still in tact with the comments on the header and on the file. Or in other words, the only way to discard a draft from the UI should be by clicking the discard button.  This hidden discard by submitting a blank comment feature is bound to lose user data accidentally.




What operating system are you using? What browser?

Any.

Please provide any additional information below.
david
#1 david
This was a momentary issue with the code in master (not 2.0.11). This is no longer a problem.
  • +Fixed