3648: rbt post of committed code not supported for Perforce

Gavin.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 12, 2014 
What version are you running?
RBTools 0.6.2

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. Try to post a submitted Perforce changelist:
rbt post <submitted perforce changelist>

What is the expected output? What do you see instead?
The changelist is not recognised and the filelog syntax is incorrect.
Error will be shown:
Failed to execute command: ['p4', '-G', 'filelog', '//...@822657,822657']
I expect that the files for that changelist will be derived and the diffs generated.

What operating system are you using? What browser?
RBTools on Windows but I don't think that is the problem.

Please provide any additional information below.
I looked at the perforce.py source and it doesn't look right for this scenario.
david
#1 david 
This should definitely work correctly. One quick question--do you have a perforce client?

Can you clarify what you mean by "doesn't look right for this scenario"? We've definitely tested posting submitted changelists.
  • +NeedInfo
#2 Gavin.******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Yes I'm using Perforce client Rev. P4/NTX86/2010.1/251161 (2010/06/16).

I understand that the initial call to p4.change will return the status as pending or submitted, and that when it's submitted there is different logic. However I don't understand p4.filelog('//...@%s,%s' % (real_base, tip)) because a revision range syntax cannot be used for a changelist number.

I think the correct syntax should be something like this which specifies a changelist number:
p4 filelog -c822657 -m1 //...

Thanks.
david
#3 david 
I believe the issue is just that your p4 command-line client is too old.
  • -NeedInfo
    +SetupIssue