364: Adding a comment on IE7 cause a JavaScript "Invalid Argument" error

raz.*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 22, 2008
What's the URL of the page containing the problem?
/scripts/rb/widgets.js

What steps will reproduce the problem?
1. Enter a review from IE7 on Vista
2. Click "add comment" in a review
3. JavaScript's invalid argument pop-up shows.

What is the expected output? What do you see instead?
Should show the comment editing box and grow it size automatically.
On Firefox it works correctly but on IE on the same box it just fails.

What operating system are you using? What browser?
Windows Vista with IE7 all latest patches.

Please provide any additional information below.
I narrow it down to the function:
    grow: function() {
        if (this.el.dom.scrollHeight > this.el.dom.clientHeight) {
            this.size += 2;
            this.el.setHeight(this.getHeight());
            this.grow();
        }
in the file widgets.js. The problem is that this.size return NaN for some
reason so the call to setHeight fails later on to set the height of the
comments' text area object as it tries to set it to NaNpx.
david
#1 david
  • +Milestone-Release1.0
chipx86
#2 chipx86
This shouldn't happen anymore, and I can't reproduce it. This code was completely
rewritten. If it still happens for you, though, please reopen.
  • +Fixed