359: unable to view the diff - no specific error code

farshi*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 5, 2008
What's the URL of the page containing the problem?
After attaching a new diff i am not able to view the diff.
cl number is : 8674
 
here is the error code:



The patch to '/***/**/***/***/**/IVirtualMachine.java' didn't apply
cleanly. The temporary files have been left in '/tmp/reviewboard.RwrpmL'
for debugging purposes. `patch` returned: patching file
/tmp/reviewboard.RwrpmL/tmpk_Xpth

Traceback (most recent call last):
  File "/root/reviewboard/diffviewer/views.py", line 78, in view_diff
    files = get_diff_files(diffset, None, interdiffset, highlighting)
  File "/root/reviewboard/diffviewer/diffutils.py", line 535, in get_diff_files
    enable_syntax_highlighting)
  File "/root/reviewboard/diffviewer/diffutils.py", line 475, in generate_files
    lambda: get_chunks(filediff.diffset,
  File "/root/reviewboard/djblets/util/misc.py", line 44, in cache_memoize
    data = lookup_callable()
  File "/root/reviewboard/diffviewer/diffutils.py", line 478, in <lambda>
    enable_syntax_highlighting))
  File "/root/reviewboard/diffviewer/diffutils.py", line 277, in get_chunks
    new = get_patched_file(old, filediff)
  File "/root/reviewboard/diffviewer/diffutils.py", line 190, in
get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
  File "/root/reviewboard/diffviewer/diffutils.py", line 91, in patch
    (filename, tempdir, p.stdout.read()))
Exception: The patch to '/***/**/***/***/**/IVirtualMachine.java.java'
didn't apply cleanly. The temporary files have been left in
'/tmp/reviewboard.RwrpmL' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.RwrpmL/tmpk_Xpth



What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.
#1 damien******@gmai***** (Google Code) (Is this you? Claim this profile.)
Steps to reproduce:
1. create a new file (e.g. perl script) that is open for add.
2. no trailing new line (actually i tried to upload diffs again with trailing newline
and still fails)
3. post-review

e.g. of diff:
      1 --- Perl/userworld.pl  //depot/non-framework/userworld.pl#1
      2 +++ Perl/userworld.pl  08-01-28 15:58:51
      3 @@ -0,0 +1,150 @@
chipx86
#2 chipx86
I have a bug filed for this. It's more recent than this one, but I'm going to mark it
as a dup nonetheless.

Closing as duplicate of bug 386.
  • +Duplicate
  • +Component-DiffParser