3564: rbt post for Perforce fails with modified binary files

ric****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 30, 2014
What version are you running?

RBTools 0.6.2

What's the URL of the page containing the problem?

n/a

What steps will reproduce the problem?
1. p4 edit an existing binary file and modify it
2. p4 change to create a changelist with only the modified binary file
3. rbt post the p4 changelist

What is the expected output? What do you see instead?

expected: rbt successfully posts the change list to review board server
what happend: rbt fails with "rbtools.commands.CommandError: There don't seem to be any diffs!"

What operating system are you using? What browser?

OS X 10.9.4, Chrome v37
Ubuntu x86 12.04, Chrome v37

Please provide any additional information below.

This issue does NOT exist in RBTools 0.6.0. 

Although rbt 0.6.2 can post change list that has text files, any binary file in the change list will simply disappear in the posted review.
david
#1 david
That should still be the case with 0.6.2, but as you said, you have only the binary file in the changelist. There's nothing to post.
  • +NotABug