351: review tries to publish when you hit enter to save a field

cuv****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Jan. 14, 2008 
What's the URL of the page containing the problem?
/r/#/

What steps will reproduce the problem?
1. Start a new review request
2a. (IE) Just enter a summary, and hit enter.  The form will try to publish.
2b. (Firefox) Edit the summary 7 times, saving the field each time.  On the
7th time, the form tries to publish.

What is the expected output? What do you see instead?
The field is saved, but then the form tries to submit and publish (which
fails since there are no reviewers).

What operating system are you using? What browser?
Windows XP SP2, Firefox 2.0.0.11
Windows XP SP2, Internet Explorer 6.0 SP2
Windows Vista, Internet Explorer 7.0
chipx86
#1 chipx86
  • +Usability
    +Component-Reviews
chipx86
#2 chipx86
  • +Milestone-Release1.0
  • +chipx86
chipx86
#3 chipx86 
Fixed in r1120.
  • +Fixed
#4 cuv****@gmai***** (Google Code) (Is this you? Claim this profile.) 
The immediate publish on IE is fixed, but now IE shows the same behavior as Firefox
that I described in step 2b.  It counts 7 times because there are 7 fields total,
then it publishes.

This needs a simple fix, I think.  In reviews.js, gPublishing is initialized to true,
but it should be false until the publish button is actually hit.