3506: Extension review request fields are never validated

anh****@cisc***** (Google Code) (Is this you? Claim this profile.)
What version are you running?
e625b89

What's the URL of the page containing the problem?
/r/N/ for any review request N

What steps will reproduce the problem?
1. Create and enable an extension with extra fields extending BaseEditableField and/or BaseTextAreaField with is_required = True
2. Create a new review request and observe the fields displayed correctly (with a * indicating that the field is required)
3. Publish the draft with empty required fields, and submit the review request with fields still empty

What is the expected output? What do you see instead?
Something somewhere should prevent either draft publication or review request submission when required fields are empty. However, currently the draft publication and review request submission complete successfully with empty required fields.

What operating system are you using? What browser?
N/A

Please provide any additional information below.
Since the ReviewRequestApprovalHook only applies to API checks, and doesn't give any means to prevent submission on missing fields, some sort of validation process should be baked into the custom fields.
#1 anh****@cisc***** (Google Code) (Is this you? Claim this profile.)
Sorry, the title is not descriptive because I forgot to finish typing it. It should read, "Extension review request fields are never validated".
#2 smacleod
  • +Component-Extensions
  • +Extension review request fields are never validated