3455: Redundant information related to review of files should be removed

joanna.p********@gmai***** (Google Code) (Is this you? Claim this profile.)
June 30, 2014 
What version are you running?
2.0.2

What's the URL of the page this enhancement relates to, if any?
http://<review_board_url>/r/<review_request_number>/

Describe the enhancement and the motivation for it.
Redundant information related to review of files should be removed.
There is no need to put each comment content twice in a review view. What is more, displaying information in markdown syntax is not convenient for the users to read (see picture attached).

What operating system are you using? What browser?
Windows 7, Mozilla Firefox 30.0

Please provide any additional information below.
david
#1 david 
The issue here is that for some reason, you're not seeing the images. It *should* show the sections of the image that were selected for each comment. Instead, it's just showing the 'alt' text, which is set to the un-formatted text of the comment.

You'll need to do some debugging to figure out why it's not loading those images correctly. It's probably a permissions or path issue with your web server configuration.
  • +SetupIssue
#2 joanna.p********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Ok, thank you for suggestions. I will try to figure it out and let you know about results of my investigations.
#3 joanna.p********@gmai***** (Google Code) (Is this you? Claim this profile.) 
I am afraid that it is not an issue of permissions.
Take a look at pictures attached. In some cases src is empty (src="")
and in other it is generated correctly and image is visible in Review Board.
david
#4 david 
Can you upload an image attachment and check the reviewboard log file for errors? It looks like maybe the image processing (which we do to generate thumbnails and create the comment excerpt images) is failing.
#5 joanna.p********@gmai***** (Google Code) (Is this you? Claim this profile.) 
We get the following error:

2014-07-09 14:07:52,222 - ERROR -  - Error thumbnailing image file uploaded/files/2014/07/09/231e9085-adf9-435f-a404-9682db1b1ccb__images.jpeg and saving as uploaded/files/2014/07/09/231e9085-adf9-435f-a404-9682db1b1ccb__images_800x200.jpeg: decoder jpeg not available
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.5-py2.7.egg/djblets/util/templatetags/djblets_images.py", line 121, in thumbnail
    save_image_to_storage(image, storage, miniature)
  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.5-py2.7.egg/djblets/util/templatetags/djblets_images.py", line 48, in save_image_to_storage
    image.save(file, 'png')
  File "/usr/local/lib/python2.7/dist-packages/PIL-1.1.7-py2.7-linux-x86_64.egg/Image.py", line 1406, in save
    self.load()
  File "/usr/local/lib/python2.7/dist-packages/PIL-1.1.7-py2.7-linux-x86_64.egg/ImageFile.py", line 189, in load
    d = Image._getdecoder(self.mode, d, a, self.decoderconfig)
  File "/usr/local/lib/python2.7/dist-packages/PIL-1.1.7-py2.7-linux-x86_64.egg/Image.py", line 385, in _getdecoder
    raise IOError("decoder %s not available" % decoder_name)
IOError: decoder jpeg not available

We have reinstalled PIL and later on reinstalled pillowfight but still the same error occurs.
I also attach an image which was used for testing purposes.
david
#6 david 
You likely need to install libjpeg development packages and then re-install PIL/Pillow.
#7 joanna.p********@gmai***** (Google Code) (Is this you? Claim this profile.) 
The problem disappeared when PIL was replaced by Pillow (2.4.0 or branch master version, 2.5.0 is not building, unfortunately).