3449: Viewing the diff over all revisions not possible
- UserError
- Review Board
| danger******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| June 30, 2014 | |
| 3448 |
What version are you running? RB 2.0.2 What's the URL of the page containing the problem? /r/570/diff/2/ What steps will reproduce the problem? 1. browse to a review with more than one revision 2. choose orig and the latest revision 3. What is the expected output? What do you see instead? I expect that the full diff is displayed, instead only the last revision diff is displayed. The behaviour is the same for all revisions which start at orig. If I e.g. choose 1 and 2, I get the diff from revision 1. I really miss the option to get the whole diff. With all options there is something missing What operating system are you using? What browser? debian testing / chrome Please provide any additional information below.
'orig' just means the upstream file in the repository, as specified by the diff in the other revision you select. The diff at that revision should be the full diff that you wanted to put up for review. Are you trying to upload one diff per commit to one review request? If so, then that's not a supported workflow. We're working on proper support for uploading entire commit histories, but that won't land until a later 2.x or 3.0.
-
+ NeedInfo -
+ Component-DiffViewer
yes, I was trying to add a whole commit as a new revision to the review request. So I have to wait, thanks for working on it.
-
- NeedInfo + UserError