3436: Clicking and dragging on linenumbers in diffviewer doesn't allow user to comment

mconley
mconley
mconley
July 24, 2014
What version are you running?

Trunk (2.1 alpha 0 (dev))

What's the URL of the page containing the problem?

Any diffviewer page with some code in it.

What steps will reproduce the problem?
1. Go to a diffviewer, and attempt to add a comment as usual - but start your click-drag on the line number of a line, rather than the space on either side of it.


What is the expected output? What do you see instead?

A comment box should come up.

What operating system are you using? What browser?

Firefox Nightly (33.0a1)

Please provide any additional information below.

This appears to be a regression caused by a9d5090 (https://reviews.reviewboard.org/r/5576/)
chipx86
#1 chipx86
Ick. Yeah, we need to fix that, or back out the feature.
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release2.1
    +Component-DiffViewer
david
#2 david
Backed out change in 8bfbcf0.
  • +Fixed