3408: ReviewBoard 2.0.1 - RB is undefined error on IE8

roma.k******@gmai***** (Google Code) (Is this you? Claim this profile.)
July 17, 2014 
What version are you running?



Review Board - 2.0.1

What's the URL of the page containing the problem?

http://<the url>/r/125/

What steps will reproduce the problem?
1. post review request using rbt 
2. open review request
3.

What is the expected output? What do you see instead?

I can't see the diffs. Instead the error 'RB' is undefined is shown by IE.

What operating system are you using? What browser?

Windows 7
IE 8

Please provide any additional information below.
chipx86
#1 chipx86 
I can't reproduce this. Can you provide the full JavaScript error log?

Do you see this with any other browsers on that system?
  • +NeedInfo
#2 ke***@keithmo******* (Google Code) (Is this you? Claim this profile.) 
Also seeing this here.  Works fine in Firefox 29 and Chrome 32

'RB' is undefined: diff, line 442 character 5
'RB' is undefined: diff, line 455 character 5

Those line correspond to
    RB.UserSession.create({

        authenticated: false,
        loginURL: "/account/login/"

    });
and
    RB.PageManager.setPage(new RB.DiffViewerPageView({
...
#3 ke***@keithmo******* (Google Code) (Is this you? Claim this profile.) 
If I add
PIPELINE_MIMETYPES = (
    (b'text/coffeescript', '.coffee'),
    (b'text/less', '.less'),
    (b'text/javascript', '.js'),
    (b'text/x-sass', '.sass'),
    (b'text/x-scss', '.scss')
)
to my settings_local.py (the newer django pipelines defaults to application/javascript, which IE8 doesn't like), I get further but still fail:

  'XMLHttpRequest.prototype' is null or not an object  base.min.9bf67e7ea227.js, line 1 character 12697
  'XMLHttpRequest.prototype' is null or not an object  base.min.9bf67e7ea227.js, line 1 character 12697
  'RB.UserSession' is null or not an object  diff, line 421 character 5
  'RB.UserSession' is null or not an object  diff, line 421 character 5
  'RB.ReviewRequest.CLOSE_DISCARDED' is null or not an object  reviews.min.00ba5bbcb4cb.js, line 3 character 31396
  'RB.ReviewRequest.CLOSE_DISCARDED' is null or not an object  reviews.min.00ba5bbcb4cb.js, line 3 character 31396
  'RB.PageManager' is null or not an object  diff, line 434 character 5
  'RB.PageManager' is null or not an object  diff, line 434 character 5
chipx86
#4 chipx86 
Unfortunately, too many things we depend on do not support IE8. It's just, at this point, too old, too broken a browser, and one we've dropped support for.

Can your company upgrade to anything modern?
chipx86
#5 chipx86 
So that being said, I spent a few minutes with this. Adding those PIPELINE_MIMETYPES and then dropping in es5-shim.min.js (https://github.com/es-shims/es5-shim) seems to allow it to function.

It does, however, fail 120 of our unit tests, with no useful errors, and it's very slow. So, we still won't officially support it, but you can play with it, and I'll accept reasonable patches to get things working.
david
#6 david
  • -NeedInfo
    +WontFix