3388: Diffs are broken on demo.reviewboard.org

dan***@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
May 28, 2014
What version are you running?

demo.reviewboard.org is running ReviewBoard-2.0.1.dev_20140525_180235

What's the URL of the page containing the problem?

http://demo.reviewboard.org/r/2/diff/1-2/

What steps will reproduce the problem?
1. Open that URL.

What is the expected output? What do you see instead?

A diff.

What operating system are you using? What browser?

Mac OS X / Chrome

Please provide any additional information below.

Where the diff would show up, I get this message and stack trace:

 There was an error displaying this diff.

The file 'reviewboard/reviews/fields.py' (rc0399b851b347d61ee674148da93b418c04ff91b) could not be found in the repository

This may be a bug in the software, a temporary outage, or an issue with the format of your diff.

Please try again, and if you still have trouble, contact support.

Details
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/diffviewer/views.py", line 236, in get
    renderer = self.create_renderer(context, *args, **kwargs)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/reviews/views.py", line 1102, in create_renderer
    *args, **kwargs)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/diffviewer/views.py", line 326, in create_renderer
    self.diff_file = self._get_requested_diff_file()
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/diffviewer/views.py", line 367, in _get_requested_diff_file
    request=self.request)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 373, in populate_diff_chunks
    chunks = generator.get_chunks()
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/diffviewer/chunk_generator.py", line 148, in get_chunks
    large_data=True)
  File "/usr/lib/python2.6/site-packages/Djblets-0.8.1alpha0.dev_20140525_174211-py2.6.egg/djblets/cache/backend.py", line 109, in cache_memoize
    data = lookup_callable()
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/diffviewer/chunk_generator.py", line 147, in <lambda>
    lambda: list(self._get_chunks_uncached()),
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/diffviewer/chunk_generator.py", line 154, in _get_chunks_uncached
    old = get_original_file(self.filediff, self.request, encoding_list)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 169, in get_original_file
    request=request)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/scmtools/models.py", line 219, in get_file
    large_data=True)[0]
  File "/usr/lib/python2.6/site-packages/Djblets-0.8.1alpha0.dev_20140525_174211-py2.6.egg/djblets/cache/backend.py", line 109, in cache_memoize
    data = lookup_callable()
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/scmtools/models.py", line 218, in <lambda>
    request)],
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/scmtools/models.py", line 368, in _get_file_uncached
    base_commit_id=base_commit_id)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.0.1.dev_20140525_180235-py2.6.egg/reviewboard/hostingsvcs/github.py", line 404, in get_file
    raise FileNotFoundError(path, revision)
FileNotFoundError: The file 'reviewboard/reviews/fields.py' (rc0399b851b347d61ee674148da93b418c04ff91b) could not be found in the repository
chipx86
#1 chipx86
Huh. That was working..

Let me look into it.
  • +Confirmed
  • +chipx86
chipx86
#2 chipx86
An OAuth token got deleted on GitHub's side. This is now fixed. Thanks for reporting it!
  • -Confirmed
    +Fixed