3354: TypeError for "New Review Request" and "View Diff" after updade to Review Board 2.0

Nicolas*******@gmai***** (Google Code) (Is this you? Claim this profile.)
June 11, 2014
What version are you running?
Review Board 2.0

What's the URL of the page containing the problem?
http://xxx/reviews/r/new/
or 
http//xxx/review/r/1671/diff/#index_header

What steps will reproduce the problem?
1.New Review Request
or
1. Open a Review Request
2. View Diff

What is the expected output? What do you see instead?
A page to create a new Review Request
Or
A page to view diff for a Review

What operating system are you using? What browser?
OS: Debian
Browser: Google Chrome / Internet Explorer

Please provide any additional information below.

Hello,

After an update from Review Board from 1.7.24 to 2.0, we cannot create a new Review or see diff on existing one, so it's quite blocking.

Everytime we want to create or to see a review, we get the following error : "expected string or Unicode object, client.ConfigItem found".
The full Debug file is attached for "New Review Request" issue.

We don't have any problem to navigate throw pages and we can modify admin elements in the Admin Dashboard.

Thanks,
Best regards.
<!DOCTYPE html>
<!-- saved from url=(0033)http://MyServerName/reviews/r/new/ -->
<html lang="en"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  <meta name="robots" content="NONE,NOARCHIVE">
  <title>TypeError at /reviews/r/new/</title>
  <style type="text/css">
    html * { padding:0; margin:0; }
    body * { padding:10px 20px; }
    body * * { padding:0; }
    body { font:small sans-serif; }
    body>div { border-bottom:1px solid #ddd; }
    h1 { font-weight:normal; }
    h2 { margin-bottom:.8em; }
    h2 span { font-size:80%; color:#666; font-weight:normal; }
    h3 { margin:1em 0 .5em 0; }
    h4 { margin:0 0 .5em 0; font-weight: normal; }
    code, pre { font-size: 100%; white-space: pre-wrap; }
    table { border:1px solid #ccc; border-collapse: collapse; width:100%; background:white; }
    tbody td, tbody th { vertical-align:top; padding:2px 3px; }
    thead th { padding:1px 6px 1px 3px; background:#fefefe; text-align:left; font-weight:normal; font-s
chipx86
#1 chipx86
Do you have any kind of custom Subversion configuration file being used with Review Board?

Was Apache restarted after the upgrade? The lines shown in the trace don't make much sense with regard to the error message.
  • +NeedInfo
#2 Nicolas*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Hello,

THe only customization present on my Subversion is a post-commit hook to call RBTools.
Apache has been restarted after the upgrade.

A new RB site has been created and the database compared to the existing one, but no difference appears.

Thanks,
Best regards.
#3 Nicolas*******@gmai***** (Google Code) (Is this you? Claim this profile.)
As a complement of information, I have the same issue when I want to view the diff of an existing review. Debug info is not as complete as in the previous attached file but it's the same error.
----
expected string or Unicode object, client.ConfigItem found

Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-2.0-py2.6.egg/reviewboard/diffviewer/views.py", line 94, in get
    *args, **kwargs)
  File "/usr/local/lib/python2.6/dist-packages/Django-1.6.5-py2.6.egg/django/views/generic/base.py", line 154, in get
    context = self.get_context_data(**kwargs)
  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-2.0-py2.6.egg/reviewboard/reviews/views.py", line 867, in get_context_data
    make_review_request_context(self.request, self.review_request))
  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-2.0-py2.6.egg/reviewboard/reviews/context.py", line 92, in make_review_request_context
    upload_diff_form = UploadDiffForm(review_request, request=request)
  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-2.0-py2.6.egg/reviewboard/reviews/forms.py", line 102, in __init__
    history=review_request.diffset_history_id).latest()
TypeError: expected string or Unicode object, client.ConfigItem found
----

Best regards.
chipx86
#4 chipx86
Are you guys using PySVN, or Subvertpy? Do you have Subvertpy installed?

Christian
#5 Nicolas*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Hello,

As it's an old Review Board installation, we have both PySVN and Subvertpy installed.
subversion is also present on the environment.

Here are the versions :
- python-subvertpy : 0.7.3-1
- python-svn : 1.7.2-3
- subversion : 1.6.12dfsg-7

Thanks.
Best regards,
chipx86
#6 chipx86
Subvertpy is newer and somewhat experimental, and it looks like it has some issues. PySVN is going to be better-supported, so if you can remove subvertpy, you may want to do that for now until we figure out what it's doing.
#7 Nicolas*******@gmai***** (Google Code) (Is this you? Claim this profile.)
subvertpy has been removed and Review Board works well.

Issue solved.
Many thanks for your help !

Best regards.
david
#8 david
This traceback is nonsense, and I can't even find ConfigItem used in the latest subvertpy code (it's still defined, but nothing seems to use it). I'm going to call this 3rdparty and assume it's fixed upstream.
  • -NeedInfo
    +ThirdParty