3352: The publish change dialog doesn't show up when a field is edited

pval****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
June 5, 2014
3357 
What version are you running?
2.0

What's the URL of the page containing the problem?
/r/304

What steps will reproduce the problem?
1. Open an existing review
2. Edit the description (for example)
3. Click the OK button bellow the description

What is the expected output? What do you see instead?
The "This review request is a draft" dialog should show up at the top of the page but it doesn't.
For it to show up, you have to go to another page like "View diff" for example.

What operating system are you using? What browser?
Linux Ubuntu 14.04 with Chrome 34.0.1847.137

Please provide any additional information below.
That was working fine with 1.7.24
david
#1 david 
Can you clear your browser cache and try again?

If that still fails, can you check the browser console (Tools > JavaScript Console) and see if there are any errors when you change a field?
  • +NeedInfo
#2 christop*********@delph****** (Google Code) (Is this you? Claim this profile.) 
I see this issue as well in Firefox 29.0.1 on Linux and IE11 on Windows. Clearing my browser cache does not help. Any time I update a field on a review request I get an error similar to the following in my javascript console (this error is from chrome):

GET http://<ip removed>/api/review-requests/16265/draft/?api_format=json&expand=depends_on%2Ctarget_people%2Ctarget_groups 404 (NOT FOUND)
jquery-1.8.2.min.cfa9051cc0b0.js:2
send jquery-1.8.2.min.cfa9051cc0b0.js:2
p.extend.ajax jquery-1.8.2.min.cfa9051cc0b0.js:2
doCall base.min.221a1f3c7761.js:1
RB.apiCall base.min.221a1f3c7761.js:1
Backbone.ajax base.min.221a1f3c7761.js:1
a.sync 3rdparty.min.787bbc6b4fd2.js:4
RB.BaseResource.Backbone.Model.extend.sync base.min.221a1f3c7761.js:1
h.extend.fetch 3rdparty.min.787bbc6b4fd2.js:3
RB.DraftResourceModelMixin._retrieveDraft base.min.221a1f3c7761.js:1
sup.ready.call._.defaults.ready base.min.221a1f3c7761.js:1
RB.BaseResource.Backbone.Model.extend.ready base.min.221a1f3c7761.js:1
RB.BaseResource.Backbone.Model.extend.ready base.min.221a1f3c7761.js:1
RB.DraftResourceModelMixin.ready base.min.221a1f3c7761.js:1
RB.BaseResource.Backbone.Model.extend.save base.min.221a1f3c7761.js:1
RB.ReviewRequestEditor.Backbone.Model.extend.setDraftField reviews.min.2f31eb11f43f.js:1
(anonymous function) reviews.min.2f31eb11f43f.js:4
p.event.dispatch jquery-1.8.2.min.cfa9051cc0b0.js:2
g.handle.h jquery-1.8.2.min.cfa9051cc0b0.js:2
p.event.trigger jquery-1.8.2.min.cfa9051cc0b0.js:2
p.fn.extend.triggerHandler jquery-1.8.2.min.cfa9051cc0b0.js:2
$.widget.save jquery.gravy.min.1dec384a75c9.js:1
$.widget.submit jquery.gravy.min.1dec384a75c9.js:1
(anonymous function) jquery.gravy.min.1dec384a75c9.js:1
p.event.dispatch jquery-1.8.2.min.cfa9051cc0b0.js:2
g.handle.h jquery-1.8.2.min.cfa9051cc0b0.js:2
chipx86
#3 chipx86 
I can reproduce this. Looking into it.
  • -NeedInfo
    +Confirmed
  • +Milestone-Release2.0
  • +chipx86
chipx86
#4 chipx86
chipx86
#5 chipx86 
Fix pending at https://reviews.reviewboard.org/r/5848/
  • -Confirmed
    +PendingReview
chipx86
#6 chipx86
  • -PendingReview
    +Fixed