3339: 2.0RC3: ldap.open() is deprecated - use ldap.initialize() instead

bruce*****@gmai***** (Google Code) (Is this you? Claim this profile.)
May 12, 2014 
What version are you running?
2.0 RC3

What's the URL of the page containing the problem?
/account/login

What steps will reproduce the problem?
1. Set up Review Board to use Active Directory authentication
2. Login

What is the expected output? What do you see instead?
The following appears in reviewboard.log:

/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0rc3-py2.7.egg/reviewboard/accounts/backends.py:595: DeprecationWarning: ldap.open() is deprecated! Use ldap.initialize() instead.
   con = ldap.open(host, port=int(port))

What operating system are you using? What browser?
Windows 8.1 and Firefox 29
david
#1 david 
Fixed in master (5e001f7). Thanks!
  • +Fixed
#2 bruce*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Should this have been fixed in 2.0.x? It appears it's only in master (https://github.com/reviewboard/reviewboard/blob/release-2.0.x/reviewboard/accounts/backends.py).
chipx86
#3 chipx86 
I just copied this to the 2.0 branch. It'll be part of the 2.0.2.