3326: PostReview: "movedFile" field doesn't exist after a P4 submit and updating review with new change number generated by p4 submit fails

satish3
May 9, 2014
2272 
What version are you running?
RBTools0.4.3

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.Create a P4 change with move/delete files.
2.Post a review with the change number generated in step 1.
3.P4 submit the change, you will get a new Change Number.
4.Update the review created in step 2 with the new change number.
5.Post review fails:
     Unable to get necessary fstat information on //demo.py

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.
david
#1 david 
What version of review board?

How are you updating the change number?
david
#2 david
  • +NeedInfo
#3 satish3 
The version of Review Board is 1.7.7.1
I am updating change number by the below command:
post-review -r review_id new_change_no
david
#4 david 
So when you do that, you're actually uploading a new diff, and rbtools < 0.6 is completely broken with submitted changelists. You'll probably do better with 0.6, but fundamentally the real issue is that we want to be able to update the listed changelist number without needing a new revision of the diff.