323: Draft diffs are added to the review request's diffset history, making them public.

vas****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
March 10, 2008 
What's the URL of the page containing the problem?
http://reviewboard.eng.vmware.com/r/7391/diff/#index_header

What steps will reproduce the problem?
1. Update Attached Diff.
2. Click Discard Draft.
3. Change the diff a little.
4. Update Attached Diff once again.
5. Go to ViewDiff.

What is the expected output? What do you see instead?
The last diff should be visible. Instead an error text appears saying patch
does not apply cleanly.

What operating system are you using? What browser?
Linux (ubuntu), Firefox 2.0.0.11

Please provide any additional information below.
Perforce is used as the source control system.
chipx86
#1 chipx86
  • -Priority-Medium
    +Priority-High
    +Component-DiffViewer
    +Interdiffs
chipx86
#2 chipx86
  • +Milestone-Release1.0
grossag
#3 grossag 
I think the answer to this is to remove a diff from the diff history if it is
discarded.  That would work the best for me.
chipx86
#4 chipx86 
The core problem seems to be that when uploading a diff to a draft, the diffset gets
added to the review request's DiffSetHistory, making it public. We also never delete
it when deleting the draft. It doesn't happen automatically when deleting the draft
because it exists in the history too early.

We just need to not put it in the review request's diffset history. This should fix
the interdiff issue.
  • -Interdiffs
  • +Draft diffs are added to the review request's diffset history, making them public.
chipx86
#5 chipx86
  • +Fixed
  • +chipx86