322: Reviewboard email should contain links to the comments on the review request tab, not on the diff tab

jameslin
david
david
Jan. 27, 2008
If I make comments on someone's diff, the email that gets sent out says:

----

//some/file/path
<http://reviewboard/r/7561/diff/4/#file126037line406>

    My comment goes here.

----

I think it'd be better to link to the comments on the review request tab,
not on the diff tab (and maybe even open up an edit box to reply to that
comment).  Bringing people to the diff page is kind of bad, because the way
reviewboard currently works, it's not the right place to reply to review
comments since their replies won't be nested properly. (And clearly people
have fallen into that trap.)

Alternatively, maybe it'd be nice if comments shown on the diff tab had a
"Reply" link so that people can reply there with proper comment nesting.
david
#1 david
  • +Component-EMail
chipx86
#2 chipx86
  • +Milestone-Release1.0
david
#3 david
  • +Started
  • +david
david
#4 david
Fixed in SVN.  Thanks!
  • -Started
    +Fixed