3152: Comment window doesn't show TextArea in the right color. Text itself scrolls on making entries

amit.praka**********@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 10, 2013
3150
What version are you running?
reviewboard 2.0b1

What's the URL of the page containing the problem?
[reviewboard_url]/r/[review_number]/diff/#

What steps will reproduce the problem?
1. View diff for a review
2. Click on any line of code to comment on it
3. Type comments in the comment box that pops out

What is the expected output? What do you see instead?
One should see a textarea to enter comments into. It should behave identical to a text-area when user inputs a comment.
Instead there is no demarcation b/w the textarea and the background and the text scrolls as one types i.e. the position of the div inside <div class='CodeMirror cm-s-default CodeMirror-wrap'> keeps changing to a lower and lower position on screen.

What operating system are you using? What browser?
Linux, Firefox
#1 sat****@gmai***** (Google Code) (Is this you? Claim this profile.)
I am also facing the same issue with text edit boxes
chipx86
#2 chipx86
Seems to be a common issue for some people. Can you show me the 'ls -l' of /path/to/site/htdocs/static, and also show all the <link> tags in the source for that page?
  • +NeedInfo
#3 amit.praka**********@gmai***** (Google Code) (Is this you? Claim this profile.)
drwxr-xr-x 2 www-data www-data 4096 Dec  3 12:01 .
drwxr-xr-x 4 www-data www-data 4096 Dec  3 11:59 ..
lrwxrwxrwx 1 root     root      114 Dec  3 11:56 admin -> /data/venv/review/local/lib/python2.7/site-packages/ReviewBoard-2.0beta1-py2.7.egg/reviewboard/htdocs/static/admin
lrwxrwxrwx 1 root     root      104 Dec  3 12:01 djblets -> /data/venv/review/lib/python2.7/site-packages/Djblets-0.8alpha1-py2.7.egg/djblets/htdocs/static/djblets/
-rwxr-xr-x 1 www-data www-data  522 Dec  3 11:56 .htaccess
lrwxrwxrwx 1 root     root      112 Dec  3 11:56 lib -> /data/venv/review/local/lib/python2.7/site-packages/ReviewBoard-2.0beta1-py2.7.egg/reviewboard/htdocs/static/lib
lrwxrwxrwx 1 root     root      111 Dec  3 11:56 rb -> /data/venv/review/local/lib/python2.7/site-packages/ReviewBoard-2.0beta1-py2.7.egg/reviewboard/htdocs/static/rb
#4 amit.praka**********@gmai***** (Google Code) (Is this you? Claim this profile.)
link rel="shortcut icon" type="image/x-icon" href="/static/rb/images/favicon.ico" />
  <link rel="apple-touch-icon-precomposed" type="image/png" href="/static/rb/images/apple-home-icon.png" />
<link href="/static/rb/css/common.min.css" rel="stylesheet" type="text/css" />
<link href="/static/rb/css/reviews.min.css" rel="stylesheet" type="text/css" />
  <link rel="stylesheet" type="text/css" href="/static/rb/css/ie_hacks.css"></script>
#5 amit.praka**********@gmai***** (Google Code) (Is this you? Claim this profile.)
<script type="text/javascript" src="/static/lib/js/jquery-1.8.2.min.js"></script>
<script src="/jsi18n/"></script>
<script type="text/javascript" src="/static/lib/js/jquery-ui-1.8.24.custom.min.js"></script>
<script   type="text/javascript" src="/static/lib/js/3rdparty.min.js" charset="utf-8"></script>
<script   type="text/javascript" src="/static/djblets/js/jquery.gravy.min.js" charset="utf-8"></script>
<script   type="text/javascript" src="/static/djblets/js/extensions.min.js" charset="utf-8"></script>
  <script   type="text/javascript" src="/static/rb/js/base.min.js" charset="utf-8"></script>
  <script>
<script   type="text/javascript" src="/static/rb/js/reviews.min.js" charset="utf-8"></script>
chipx86
#7 chipx86
That's suspicious. The filenames should be things like "3rdparty.min.SOMEID.js".

Do you have DEBUG set to True in settings_local.py?
#8 amit.praka**********@gmai***** (Google Code) (Is this you? Claim this profile.)
Yes, DEBUG was set to True. Changing it to false however, does change the filename for the  js scripts as pointed out but does not result in change of behavior. 

<script type="text/javascript" src="/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js"></script>
<script src="/jsi18n/"></script>
<script type="text/javascript" src="/static/lib/js/jquery-ui-1.8.24.custom.min.f6148fb67d77.js"></script>
<script   type="text/javascript" src="/static/lib/js/3rdparty.min.2eac1e227279.js" charset="utf-8"></script>
<script   type="text/javascript" src="/static/djblets/js/jquery.gravy.min.08c3967a10f4.js" charset="utf-8"></script>
<script   type="text/javascript" src="/static/djblets/js/extensions.min.1806a6eb2d61.js" charset="utf-8"></script>
<script   type="text/javascript" src="/static/rb/js/base.min.af3ec691f218.js" charset="utf-8"></script>
<script   type="text/javascript" src="/static/rb/js/reviews.min.d2c692a46e77.js" charset="utf-8"></script>
david
#9 david
Can you check whether those files are loaded properly when you load the page? You may want to try clearing the browser cache.
#10 amit.praka**********@gmai***** (Google Code) (Is this you? Claim this profile.)
Hi, I've tried clearing the cache, ctrl + shift + reload and a separate browser. Does not resolve the issue. Furthermore, since the files[filenames] being requested by the site itself have changed, there shouldn't have been anything cached for the resources anyway.
#11 amit.praka**********@gmai***** (Google Code) (Is this you? Claim this profile.)
Any updates on this?
chipx86
#12 chipx86
We are unable to reproduce it, but we know other people have hit it as well.

Can you attach your common.*.min.css file that the page references? We need to figure out why the CSS rules for that widget are missing.

There will likely be a new beta release coming out soon, once we've finished testing some important bits of it.
#13 amit.praka**********@gmai***** (Google Code) (Is this you? Claim this profile.)
Attached common.min.ccacd15c8a12.css
  • +
    /* RB Colors */
    /*
     * At least on Chrome, using points instead of pixels does not reliably
     * result in identical sizings when there are elements positioned inside
     * a <pre>. Pixels fixes this.
     */
    /* !(*%!(&^ (see http://www.positioniseverything.net/easyclearing.html) */
    .clearfix {
      display: inline-block;
    }
    .clearfix:after {
      clear: both;
      content: ".";
      display: block;
      height: 0;
      visibility: hidden;
    }
    /* Hides from IE-mac \*/
    * html .clearfix {
      height: 1%;
    }
    .clearfix {
      display: block;
    }
    /* End hide from IE-mac */
    body {
      background-color: white;
      color: black;
      font-family: Verdana, Arial, Helvetica, Sans-Serif;
      font-size: 8pt;
      margin: 0;
      padding: 0;
    }
    form th {
      text-align: right;
      vertical-align: top;
    }
    h1 {
      font-size: 10pt;
    }
    h3 {
      margin-top: 2em;
    }
    img {
      border: 0;
    }
    label.required {
      font-weight: bold;
    }
    pre,
chipx86
#14 chipx86
Fixed for beta 2.
  • -NeedInfo
    +Fixed
#15 amit.praka**********@gmai***** (Google Code) (Is this you? Claim this profile.)
When is rb2b2 expected?