3149: reviewboard doesn't use sender email setting
- NotABug
- Review Board
| leo.shk*******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Dec. 6, 2013 |
What version are you running? 1.7.12 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. Set email sender to foo@bar.com in admin 2. Do reviewboard action as user@bar.com that's triggered to send email 3. What is the expected output? What do you see instead? Expected: mail has a From header of foo@bar.com Instead: mail has a From header that says user@bar.com This behavior worked properly as per - http://www.reviewboard.org/docs/manual/dev/admin/configuration/email-settings/#sender-email-address - in 1.6.X What operating system are you using? What browser? N/A Please provide any additional information below. The new behavior creates a real problem in gmail as there's no way using gmail's filtering to tell apart an auto-generated email from reviewboard and one that's sent by a human in response (or followup). With the behavior as documented, one could look for the From address to come out of ReviewBoard. Unfortunately, there's no way in gmail to filter on the other headers that identify the email as an automatically generated one.
Just upgraded to 1.7.19 - this is still an issue - the Sender header now says "foo@bar.com" but the From is still "user@bar.com". Unfortunately there's no way to filter on Sender in gmail.
As per RFC 2822, and the Sender Policy Framework spec (RFC 4408) the Sender field should be the address of the agent sending the message (the server, so foo@bar.com in your example), and From should be the address of the author of the message (whether manually sent by them, or by a service on their behalf -- user@bar.com). So, we're doing the correct thing. The issue of filtering in gmail is separate. What I personally do is filter two things: 1) The destination address (assuming e-mails are being sent to a specific reviews list), and 2) "Review Request" in the subject. It's not ideal, and I wish gmail would add support for filtering on other headers, but that's a bug to file against them. We're operating according to spec, whereas for a brief time in 1.6.x, we had a bug that swapped these values.
-
+ NotABug
Thanks for the response. You're correct about the RFC. I re-read the reviewboard doc I linked to and it's a little confusing. With respect to filtering in gmail, neither of the approaches you're using work for us. Reviews are sent to some set of individuals rather than one list for the company so #1 doesn't work and #2 doesn't work since it would also capture people manually replying to the emails. Given that gmail is probably a pretty significant percentage of reviewboard users, it might be worth adding an option to workaround this issue and do the "incorrect" value for the From.
We won't be doing the incorrect thing, since that'll just lead to more confusion for users, issues in environments where different e-mail clients are used, and a massive support nightmare for us. This really needs to be fixed on the gmail side of things. Maybe try adding "This is an automatically generated e-mail" to your filter, for the content?
Fair. Thanks for considering the issue. Unfortunately, I can't filter on any text in the email itself since someone replying to it will contain the same text.