3105: Can't post diffs containing non-ascii characters in file name

leon*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 28, 2014 
What version are you running?
Review Board 1.7.14


What's the URL of the page containing the problem?
http://192.168.238.129/r/new/

What steps will reproduce the problem?
1. Add file with russian name to repository
2. Create patch with TortoiseSVN
3. Try to add patch to review

What is the expected output? What do you see instead?
I expect new review but I get this message instead:
'ascii' codec can't decode byte 0xca in position 0: ordinal not in range(128)

What operating system are you using? What browser?
Review Board:
Debian 6

Workstation:
Windows 7 + Google Chrome (Version 30.0.1599.69 m)

Please provide any additional information below.
If I use english titles I get correct workflow (even if there is any russian word). So if I use russian titles I get error.
It does not matter if I rename diff file.
It's OK if russian words in the body of file.
Картинка 22.png.patch 
Index: �������� 22.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: �������� 22.png
===================================================================
--- �������� 22.png	(revision 0)
+++ �������� 22.png	(working copy)
Property changes on: �������� 22.png
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property

 






 

  pic22.png.patch
  



    
     
    


  

 


 

  
 
Index: �������� 22.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: �������� 22.png
===================================================================
--- �������� 22.png	(revision 0)
+++ �������� 22.png	(working copy)
Property changes on: �������� 22.png
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property

 






 

  new.txt.patch
  



    
     
    


  

 


 

  
 
Index: ����� ����.txt
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: ����� ����.txt
===================================================================
--- ����� ����.txt	(revision 0)
+++ ����� ����.txt	(working copy)
Property changes on: ����� ����.txt
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property

 






 

  screenshot.png
  



    
     
    


  

 


 

  
   None 

 






  


 










 

  

   david

  

 
 

  

    
     

   
   #1
   david


  


  
I know it's been a while since you filed this, but can you attach a copy of the reviewboard log file after reproducing this issue?



  
    


   
  • 
    
    
    +NeedInfo
    
   
    • 


  


 








 

  

   david

  

 
 

  

    
     

   
   #2
   david


  



  
    


   
  • 
    
    
    +Component-SCMTools
    
   
    • 


  


 








 

   

 
 

  

    
     

   
   #3
   leon*****@gmai***** (Google Code)



(Is this you? Claim this profile.)


  


  
Hello. Sorry for my absence but i'm trying chef-server now... so... could You tell me please where can i get the reviewboard log file? I will attache it asap.



 








 

  

   david

  

 
 

  

    
     

   
   #4
   david


  


  
It's generally found in the 'logs' subdirectory of the site dir (the path you pass in to rb-site).



 








 

  

   david

  

 
 

  

    
     

   
   #5
   david


  



  
    


   
  • 
    
    
    -NeedInfo
    +Incomplete
    
   
    • 


  


 








 

   

 
 

  

    
     

   
   #6
   leon*****@gmai***** (Google Code)



(Is this you? Claim this profile.)


  


  
Could you help me please to enable server logs. It seems I have no such settings or module.

But there are such settings in /var/review-board/conf/settings_local.py

# Extra site information.
SITE_ID = 1
SITE_ROOT = '/'
FORCE_SCRIPT_NAME = ''
DEBUG = True


and logs folder is empty
$ ls -la /var/review-board/logs/
total 8
drwxr-xr-x 2 www-data root 4096 Oct 10 19:47 .
drwxr-xr-x 7 root     root 4096 Oct 10 19:47 ..




  

 








 

  

   david

  

 
 

  

    
     

   
   #7
   david


  


  
Click on "Logging" in the admin sidebar (under "System Settings") and you should be able to turn it on.



 








 

   

 
 

  

    
     

   
   #8
   leon*****@gmai***** (Google Code)



(Is this you? Claim this profile.)


  


  
2014-03-13 07:26:38,412 - DEBUG -  - Logging to /var/review-board/logs/reviewboard.log with a minimum level of DEBUG
2014-03-13 07:26:38,502 - DEBUG -  - DiffParser.parse: Beginning parse of diff, size = 221
2014-03-13 07:26:38,502 - DEBUG -  - DiffParser.parse: Finished parsing diff.