3097: unable to post a review with post-review
- SetupIssue
- Review Board
| ga**@sege**** (Google Code) (Is this you? Claim this profile.) | |
| Jan. 18, 2014 |
What version are you running?
1.7.14
What's the URL of the page containing the problem?
private
What steps will reproduce the problem?
1. install the version + create site
2. create subversion repository
3. install RBTools 0.5.2
4. go to svn trunk directory
5. prepare .reviewboardrc with REVIEWBOARD_URL
6. execute post-review -d
What is the expected output? What do you see instead?
Expected output would be a review in the system. I see an error after message that review has been created, but in the system, nothing is present. Attached below...
What operating system are you using? What browser?
Linux Mint, Chrome
Please provide any additional information below.
>>> Review request created
Traceback (most recent call last):
File "/usr/local/bin/post-review", line 9, in <module>
load_entry_point('RBTools==0.5.2', 'console_scripts', 'post-review')()
File "/usr/local/lib/python2.7/dist-packages/RBTools-0.5.2-py2.7.egg/rbtools/postreview.py", line 1372, in main
submit_as=options.submit_as)
File "/usr/local/lib/python2.7/dist-packages/RBTools-0.5.2-py2.7.egg/rbtools/postreview.py", line 897, in tempt_fate
review_request = server.new_review_request(changenum, submit_as)
File "/usr/local/lib/python2.7/dist-packages/RBTools-0.5.2-py2.7.egg/rbtools/postreview.py", line 470, in new_review_request
return rsp['review_request']
KeyError: 'review_request'
Two questions: - Does it work if you use 'rbt post' instead of post-review? - Can you include the full output from the console?
-
+ NeedInfo
- it does not work with 'rbt post' either: $ rbt post CRITICAL:root:'ListResource' object has no attribute 'get_diffs' - output from the console for post-review in attached file
-
+
We are experiencing the same issue with Git. Today I cloned our RB 1.7.9 onto another machine (installed + copied the database, somehow), and it started doing this. It still works on the other machine, though, so it must be something with the new installation. The only apparent difference is that the new installation is running under its own domain, like review.example.com, while the original one is dev.example.com/rb...
Actually I think that this is a web server settings issue. rbt was trying to POST to http:// while the server was using SSL. Not sure why it didn't work, the server is returning redirects from http to https. Anyway, instead of using Nginx -> lighttpd I started using Nginx -> uwsgi, added UWSGI_SCHEME https in Nginx and rbt started to POST to https directly. Now it's working.
-
- NeedInfo + SetupIssue