3096: post-review with p4 fails to create a diff for a delete-readd file if the other files in the changelist have not changed.

andre*****@hotma****** (Google Code) (Is this you? Claim this profile.)
Feb. 16, 2014
What version are you running? 1.7.14


What's the URL of the page containing the problem?

The problem occurs when running post-review

What steps will reproduce the problem?
1.Create a changelist with 2 files that have not been modified, and a 3rd that is a file that was previously deleted and is being restored to the depot.
2. run post-review on the changelist "post-review 8408027 --target-people="craigc,zhindes,mmulsow" -o"

What is the expected output? 
I expect to see a new review created with the restored file showing up as a new file.  No diff should be created for the two unchanged files.


What do you see instead?

post-review 8408027 --target-people="craigc,zhindes,mmulsow" -o

Error uploading diff

The generated diff file was empty. This usually means no files were
modified in this change.

Try running with --output-diff and --debug for more information.

Warning: //ASIC/Projects/Mosquito/BuildTools/dev/1.1/vreview/Python/pytools/p4.py in your changeset is unmodified
Your review request still exists, but the diff is not attached.

Invalid output from post_review while posting a new review, exit code: 1

What operating system are you using? Windows 7
What browser? Firefox

Please provide any additional information below.
david
#1 david
Can you include the output of `post-review --debug` and `p4 opened`?
  • +NeedInfo
  • +Component-RBTools
david
#2 david
  • -NeedInfo
    +Incomplete