What's the URL of the page containing the problem?
http://reviewboard.local.network/r/60/diff/#index_header
What steps will reproduce the problem?
1. Upload a diff that fails to patch correctly
2. Fix diff to apply correctly, re-upload
3. Save review request and view diff
What is the expected output? What do you see instead?
I would expect that the new diff would apply correctly and display correctly.
What operating system are you using? What browser?
Ubuntu Gutsy (7.10) and Firefox
Please provide any additional information below.
I noticed that if I do not save the review and view the diff, it displays
correctly. However, if I save the the review request, the original error
comes back. This occurs even if the diff does not contain changes for the
original file anymore. So for example, say I have a diff that modifies the
files foo and bar. The patch to foo does not apply cleanly, and so when I
view the diff, I get an error saying that it did not apply cleanly. If I
then go back and change the diff so that it no longer modifies foo at all
(and the patch to bar applies cleanly), upload the new diff, and save the
review request, I still see the exact same error message that was
originally displayed. However, if after uploading the new diff, I do not
save the review request and instead choose to view the diff, I can see the
correct output without errors. If I then go back to view the request and
save it, the error reappears.
I am using revision 1008 of reviewboard, btw.
Thanks.
