3046: when attaching files, the file name gets truncated if longer than 30 characters or so

je**@jeffmar******** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Aug. 7, 2013
What version are you running?
1.7.12


What's the URL of the page containing the problem?
reviewboard/reviews/r/<reviewnumber>


What steps will reproduce the problem?
1. Create a review
2. Attach a file that has a long filename (> 32 chars)
3.

What is the expected output? What do you see instead?
The ".pptx" extension got truncated to ".p" ... 
And the file can't be found.

What operating system are you using? What browser?
Linux

Please provide any additional information below.
I shorted the file name to 12 characters .. tried again .. no problem.
So, appears to be overflowing some string buffer.

The original filename (as created by RB)
d2b915b5-3fbf-4579-8837-db8f915e9bb3__AAP_Multi_Solution_details_updated.p

The shortened file name:
3835fb39-21d1-46d6-b7e0-c4fc12483fb7__AAP_Multi_updated.pptx
david
#1 david
Christian has a fix for this at https://reviews.reviewboard.org/r/4394/
  • +PendingReview
  • +chipx86
david
#2 david
  • -PendingReview
    +Fixed