3041: Diffs no longer required...?

joersc*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 12, 2013 
What version are you running?
1.7.11

What's the URL of the page containing the problem?
https://[baseurl]/r/new/

What steps will reproduce the problem?
1. Create a new review
2. do not attach a diff or a file
3. click on "create review request"

What is the expected output? What do you see instead?
Expected behavior: It should fail saying you need to attach a diff or a file.
Actually does: let's you create the Review Request, even though there is nothing to review...

What operating system are you using? What browser?
Centos (server side), Windows 7 client side, Chrome Broswer

Please provide any additional information below.
It used to behave as expected (and desired) until upgrading to 1.7.11, and no longer does. I can't find anywhere in the admin portal that could require diffs/files, nor on the server conf files.
chipx86
#1 chipx86 
It's valid to have a review request without diffs, for, say, file review. This is generally done by selecting the "None - File Attachments Only" option in the repository list, but either way, it's allowed.

Is this causing problems for you? You can still upload a diff after the fact.
  • +NeedInfo
#2 joersc*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Yeah I can totally see not needing diffs IF you have a file. The problem is, you can still submit a Review Request if you don't have either... I remember not long ago (although I don't remember which version), you needed to attach something or it wouldn't let you finish making the Review Request. Was this sanity check feature removed or am I just not seeing it?

I can go through the entire workflow of publishing a Review Request without ever having a diff.
david
#3 david 
Yeah, I think we removed the validation entirely, but I don't think this is really worth fixing--I think over the next few years, we'll be tranistioning towards more flexibility re: mixing repos/diffs/attachments, and not less.
  • -NeedInfo
    +NotABug
#4 joersc*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Ok. I can totally live with that, as long as it's a purposeful decision. :)