3031: post-review tries to diff between the commited branch and master

gregie******@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 22, 2014 
What version are you running?
RBTools 0.3.4

What steps will reproduce the problem?
1. have a repo with a master branch with some commits
2. add a new empty branch
3. add a commit to the new branch
4. post-review -p --server=http://reviewboard --guess-summary --guess-description --revision-range=$oldrev:$newrev  --debug


What is the expected output? What do you see instead?
I expect post-review to only diff between the two relevant revisions. for some reason, part of what it does is this:
remote: >>> git merge-base master refs/heads/master
remote: >>> git branch -r --contains b41c522c1247254d7b5dc4fc24d25f9de50ad104
remote: >>> git diff --no-color --full-index --no-ext-diff 4d8fefd7d12d3009e58a645c2af41cd2e962fcd2..b41c522c1247254d7b5dc4fc24d25f9de50ad104
the 4d8fe commit is my master branch, for some reason post-review tries to diff it with b41c52, which is the branch i commited. 
the two branches have nothing in common, so it takes a long time for the diff to run. 

What operating system are you using? What browser?
linux

Please provide any additional information below.
i tried playing with the --parent and --tracking-branch options.. to no avail.
david
#1 david 
We probably shouldn't try to diff from the merge-base in the case where all the files are new.
  • +Confirmed
  • +Component-RBTools
david
#2 david 
Actually, after thinking about this more, I think it's probably not worth spending too much time trying to handle this use case. Empty branches are very, very rare, and it should work if you use --tracking-branch=$oldrev
  • -Confirmed
    +WontFix