3: IE6 - review request - formatting
- Fixed
- Review Board
| cae***@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| April 1, 2007 |
What's the URL of the page containing the problem? http://osiris.chipx86.com:8080/reviews/3/ What steps will reproduce the problem? 1. Go there in IE6 What is the expected output? What do you see instead? Submitter,Branch,Reviewers, etc usually shows in two columns. In IE6, this is ..well, see attached screenshot.
Rows:
"Submitter", "Branch", "Bugs Closed", "Groups", "People" are in wrong place because:
.review-request #details .label {
text-align: right; <-- (line 684, site.css)
white-space: nowrap;
}
"Reviewers" is in correct place. Name may or may not be in correct place (since
relative to "Submitter").
(Yes, I know text-align: right is technically correct. IE is freakish for css though)
This can be (partially) fixed by changing the col widths within #details, in review_detail.html, to use 0% and 50% instead of 0* and 1*. This completely fixes IE, however it has an odd interaction in FF where the edit field textboxes in the left column of them are reduced in size to the same as the right column widths. This reduces the size to about 11 characters ("12873, 4561"). This width changes when the % values are changed, so it is not statically listed in the css file. Looking in the javascript...
Change html to use 0% and 50% instead of 0* and 1* in the details section. Then change widgets.js, in fitWidthToParent function (~line 286). Make this.form.width equal to 2/3 of parentWidth. elWidth is zero on this page all the time. Is there a page where elWidth is -not- zero?
