2970: linkifyText(): URL parsing fails if URL is enclosed in XML-like tags

rich.to*******@ni.*** (Google Code) (Is this you? Claim this profile.)
Jan. 17, 2014 
What version are you running?

1.7.6

What's the URL of the page containing the problem?

e.g., review-board/r/<change>

What steps will reproduce the problem?

1. Set description to contain a URL enclosed in pseudo-XML tags: <foo>http://bar/</foo>

What is the expected output? What do you see instead?

The description should contain a link to "http://bar/" (with that highlighted)
Instead, I see a link to "http://bar/</foo" (with that highlighted).

What operating system are you using? What browser?

Chrome, either on Win7 or Arch Linux.

Please provide any additional information below.

It looks like this is due to linkifyText() immediately htmlEncode()ing the text before linkification: "http://bar/</foo" is not a particularly valid URL, but "http://bar/&lt;/foo" is.

Perhaps the fix for this is to only htmlEncode() the text between matching URLs, and not the URLs themselves?
david
#1 david 
This is fixed in the 2.0 betas.
  • +Fixed