2958: post-review with bzr crashes when using --revision-range

ceesja******@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 14, 2013
What version are you running?

Development versions of ReviewBoard+RBTools, checked out at 2013-04-19


What steps will reproduce the problem?
1. Enter a bazaar repository
2. Execute `post-review --revision-range=123..126`


What is the expected output? What do you see instead?
I get a stacktrace:

quinox@duivenkracht:~/projects/x/y ^2 $ post-review --revision-range=297..299
==> HTTP Authentication Required
Enter authorization information for "Web API" at <codereview server>
Username: quinox
Password: 
Traceback (most recent call last):
  File "/home/quinox/projects/tooling/usr/local/bin/post-review", line 3, in <module>
    postreview.main()
  File "/home/quinox/projects/tooling/usr/local/lib/python/rbtools/postreview.py", line 1292, in main
    repository_info)
ValueError: too many values to unpack



Please provide any additional information below.

I solved it by patching rbtools/clients/bazaar.py:

@@ -85,7 +85,7 @@ class BazaarClient(SCMClient):
         self._set_summary(last_revision)
         self._set_description(revision_range)
         
-        return diff
+        return (diff, None)
 
     def _get_range_diff(self, revision_range, files):
         """

(Not uploading to your reviewboard because I wrote this patch by guessing, I haven't looked at the code that calls this function)
david
#1 david
This should be fixed in the next rbtools release.
  • +Fixed