2956: post-review errors out with large number of files with 1.7.6 and perforce

labo****@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 7, 2013
What version are you running?
1.7.6

What's the URL of the page containing the problem?
This just occurs when I'm doing a post-review with a large number of files

What steps will reproduce the problem?
1. create a perforce change list that contains a large # of files
2. run post-review on that change list
3. post-review fails - probably timing out?

What is the expected output? What do you see instead?
Here is the output:
Change 235763 created with 69 open file(s).
$ post-review 235763
Traceback (most recent call last):
  File "/usr/local/bin/post-review", line 8, in <module>
    load_entry_point('RBTools==0.4.2', 'console_scripts', 'post-review')()
  File "/Library/Python/2.7/site-packages/RBTools-0.4.2-py2.7.egg/rbtools/postreview.py", line 1296, in main
  File "/Library/Python/2.7/site-packages/RBTools-0.4.2-py2.7.egg/rbtools/postreview.py", line 923, in tempt_fate
  File "/Library/Python/2.7/site-packages/RBTools-0.4.2-py2.7.egg/rbtools/postreview.py", line 564, in upload_diff
  File "/Library/Python/2.7/site-packages/RBTools-0.4.2-py2.7.egg/rbtools/postreview.py", line 783, in api_post
  File "/Library/Python/2.7/site-packages/RBTools-0.4.2-py2.7.egg/rbtools/postreview.py", line 698, in http_post
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 394, in open
    response = self._open(req, data)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 412, in _open
    '_open', req)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 372, in _call_chain
    result = func(*args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1199, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1170, in do_open
    r = h.getresponse(buffering=True)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1027, in getresponse
    response.begin()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 407, in begin
    version, status, reason = self._read_status()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 371, in _read_status
    raise BadStatusLine(line)
httplib.BadStatusLine: ''

What operating system are you using? What browser?
mac os x 10.8.3, chrome latest 

Please provide any additional information below.
This only occurs with large change lists - this change list contained 69 files
david
#1 david
Can you run with --debug and include the output here?

Also, how big is the diff it's trying to upload? You can look at the diff it makes with 'post-review --output-diff CLN'
  • +NeedInfo
david
#2 david
  • -NeedInfo
    +Incomplete