2941: "Show Whitespace changes" button is not operatonal

rad***@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Aug. 7, 2013 
What version are you running?
1.7.6

What's the URL of the page containing the problem?
https://reviewboard-openlmi.rhcloud.com/r/54/diff/

What steps will reproduce the problem?
Show/Hide Whitespace changes button doesn't do anything, just changes the button label

This might hide some issues from reviewer (e.g. indentation changes in Python code)

What is the expected output? What do you see instead?
Whitespace changes will be highlighted as any other changes.

What operating system are you using? What browser?
Fedora 18, Firefox 19.0.2
#1 ste****@gallaghe********* (Google Code) (Is this you? Claim this profile.) 
Please point out which lines of the diff there should be displaying whitespace differences as well, please. It'll make it easier to locate the problem.
#2 rad***@gmai***** (Google Code) (Is this you? Claim this profile.) 
Line 123-124:
self.print_qualifiers(p.qualifiers, param_indent+ " "*4)

got indented (because of added condition) but not highlighted.
chipx86
#3 chipx86
  • +PendingReview
  • +Milestone-Release1.7.x
    +Component-DiffViewer
  • +chipx86
david
#4 david 
This was fixed in commit 5e67070, but Christian forgot to mark the bug as fixed.
  • -PendingReview
    +Fixed
#5 jwd****@gmai***** (Google Code) (Is this you? Claim this profile.) 
What version of RB has this fix?

I am seeing the problem on 1.7.28.
chipx86
#6 chipx86 
This was fixed in 1.7.12. It's possible you're seeing a different problem. Can you go into detail on what you're seeing exactly, what your whitespace settings are, and what type of file?