284: The "groups" and "people" fields of a request are lost.

timothys*********@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 26, 2008 
What's the URL of the page containing the problem?

  http://reviewboard.eng.vmware.com/r/4817/

What steps will reproduce the problem?
Unknown at the moment.

What is the expected output? What do you see instead?
The existing "groups" and "people" values should remain the same after an
update.

What operating system are you using? What browser?
Redhat Linux, Firefox 2.0

Please provide any additional information below.

Twice now these fields have inexplicably lost their contents after an
update to the review request.  Oddly enough, the notification emails are
still sent to the appropriate groups and people, however, the "Review
request for ." line does not include the groups/people.

This is mostly a heads-up since it occurred with other people's requests
and they don't remember anything they did that might've caused this to happen.
chipx86
#1 chipx86 
We've been trying to fix this, and thought we did. Apparently not. Unfortunately, I
haven't been able to reproduce this reliably and the code doesn't look incorrect.
  • -Priority-Medium
    +Priority-Furious
grossag
#2 grossag 
I keep running into half of this bug: the people keep disappearing.  This generally
happens when I upload a diff when I already have a draft going.  For example, upload
a diff twice without publishing and the second time, you will lose all of the reviewers.
chipx86
#3 chipx86
  • +Component-Reviews
chipx86
#4 chipx86 
I believe this is now fixed in SVN, and I'll update the server this weekend. Please
let me know if you hit it again.
  • +Fixed
grossag
#5 grossag 
I want to reopen this, but I'm not sure if it's you who has to reopen it.  But I
still see that and actually don't remember a time when I didn't see it.  All you have
to do is have a review request and attach a new diff twice.  The frist time you
attach a new diff it is fine, but if you attach a new diff again without submitting
it in the meantime, it clears the Groups and People.
chipx86
#6 chipx86 
Yeah, I was wrong. It's still a bug. Our fix failed :( Reopening.
  • -Fixed
    +Accepted
chipx86
#7 chipx86
  • +Milestone-Release1.0
#8 m*@robos***** (Google Code) (Is this you? Claim this profile.) 
I've been able to reliably reproduce this with these steps:

1) update the diff via "update attached diff"
2) view diff
3) return to the review request page
4) update diff again
5) see that all the groups and people have been cleared.
chipx86
#9 chipx86 
We got it!

We'll upgrade the server this weekend.
  • -Accepted
    +Fixed