2829: Diff generation hangs when trying to "Edit Review"

joh.st*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 11, 2013 
What version are you running?
1.7.0


What's the URL of the page containing the problem?
Review page (host/r/<review-id>)


What steps will reproduce the problem?
1. Add comments to diff 
2. Click "Edit Review" to add some general comments.

What is the expected output? What do you see instead?
Expected: Page with general comments field and all code comments (incl. diffs) is shown and it is possible to edit. 

Actual outcome:
1. Browser scrolls to bottom of page, trying to show the general comments field, and the individual comments
2. No diffs are shown, only the "busy" indicator that is shown while the diff is loaded/generated. (waited several minutes)
3. It is not possible to modify the general comments field.



What operating system are you using? What browser?
Windows 7 64bit, Firefox 17.0.1

Please provide any additional information below.
If clicking "Edit Review" again while waiting for the diff generation, the "usual" (as in 1.6.x) extra page for the review pops up. Here it is at least possible to editi the general comment fiedl, but diff generation still "hangs". "Cancel" brings me back to the previous page (which is still trying to generate the diffs).
chipx86
#1 chipx86 
Can you open your browser's JavaScript debug console, reload the page, and repeat the step? Then see if there are errors in the log, and screenshot the browser window. Attach that here and I'll take a look.
  • +NeedInfo
  • +Milestone-Release1.7.x
    +Component-Reviews
#2 joh.st*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Screenshot attached. I couldn't see anything strange. Sorry, but I don't know how to change the language of the error messages.
#3 joh.st*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I was reminded today that we had installed 1.7 RC1 before for about two weeks. This issue only came up with upgrade to 1.7.0 final.
#4 xdale.******@curvede******** (Google Code) (Is this you? Claim this profile.) 
I am experiencing the same issue.

Chrome Version 23.0.1271.97 m
ReviewBoard 1.7.1

Console screenshot attached with a javascript error.
#5 superp******@gmai***** (Google Code) (Is this you? Claim this profile.) 
/*
    * Enables use of the inline editor.
    */
   enable: function() {
       if (this._editing) {
           this.showEditor();
       }

       this._editIcon.show();
       this.options.enabled = true;
   },

The error happens in this method, on the 2nd to last line. For some reason, this._editIcon is null.
david
#6 david 
This was fixed in djblets (1b79a0c1).
  • -NeedInfo
    +Fixed