2822: Raw file URL mask is not shown for Git repositories

peter.kje*********@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 11, 2012 
What version are you running?
1.6.14

What's the URL of the page containing the problem?
admin/db/scmtools/repository/1/

What steps will reproduce the problem?
1. Choose a repository that uses Git in the admin interface.
2. Choose None as hosting service.

What is the expected output? What do you see instead?
The "Raw file URL mask" field is not shown which it should be for Git repositories.

What operating system are you using? What browser?
Firefox on Linux

Please provide any additional information below.
I have attached a patch that fixes the problem.
0001-Make-the-Raw-file-URL-mask-field-show-for-Git-reposi.patch 
From 84c7977792b1bd38510e6cb1817dd5489c75a695 Mon Sep 17 00:00:00 2001
From: Peter Kjellerstedt <pkj@axis.com>
Date: Mon, 10 Dec 2012 16:20:45 +0100
Subject: [PATCH] Make the "Raw file URL mask" field show for Git repositories
---
 reviewboard/scmtools/models.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/reviewboard/scmtools/models.py b/reviewboard/scmtools/models.py
index 1252215..8d39f96 100644
--- a/reviewboard/scmtools/models.py
+++ b/reviewboard/scmtools/models.py
@@ -21,7 +21,7 @@ class Tool(models.Model):
     supports_authentication = property(
         lambda x: x.scmtool_class.supports_authentication)
     supports_raw_file_urls = property(
-        lambda x: x.get_scmtool_class.supports_raw_file_urls)
+        lambda x: x.scmtool_class.supports_raw_file_urls)
     field_help_text = property(
         lambda x: x.scmtool_class.field_help_text)
 
-- 
1.7.11.7

 






  


 










 

  

   david

  

 
 

  

    
     

   
   #1
   david


  


  
Fixed in release-1.6.x (bf30e7d). Thanks!



  
    


   
  • 
    
    
    +Fixed
    
   
    •