2818: Interdiffs are unhappy for changes that contain deleted files

jameslin
Feb. 6, 2014
3422
What version are you running?
1.6.13

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Post a review request for a change that contains deleted files.
2. Make additional edits, repost the review request.
3. View the interdiff.

What is the expected output? What do you see instead?
Deleted files show up in the interdiff with:

Diff currently unavailable.
Error: list index out of range

Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/reviewboard/diffviewer/views.py", line 380, in view_diff_fragment
  File "build/bdist.linux-x86_64/egg/reviewboard/diffviewer/views.py", line 306, in get_requested_diff_file
  File "build/bdist.linux-x86_64/egg/reviewboard/diffviewer/diffutils.py", line 1181, in populate_diff_chunks
  File "/build/toolchain/noarch/djblets-0.6.23/lib/python2.6/site-packages/djblets/util/misc.py", line 156, in cache_memoize
    data = lookup_callable()
  File "build/bdist.linux-x86_64/egg/reviewboard/diffviewer/diffutils.py", line 1180, in <lambda>
  File "build/bdist.linux-x86_64/egg/reviewboard/diffviewer/diffutils.py", line 736, in get_chunks
  File "build/bdist.linux-x86_64/egg/reviewboard/diffviewer/diffutils.py", line 479, in new_chunk
  File "build/bdist.linux-x86_64/egg/reviewboard/diffviewer/diffutils.py", line 420, in compute_chunk_last_header
IndexError: list index out of range


What operating system are you using? What browser?
Firefox 17.0.1 on Windows XP x64


Please provide any additional information below.
david
#1 david
  • +Component-DiffViewer
david
#2 david
This has been fixed for a while (definitely in 2.0)
  • +Fixed