2816: post-review (git) fails unnecessarily with explicit revision range, if implicit tracking branch does not exist

matthew********@kitwa****** (Google Code) (Is this you? Claim this profile.)
Jan. 23, 2014
What version are you running?
0.4.2

What steps will reproduce the problem?
1. Set up a git repository with no origin/master
2. post-review --revision-range=<rev1>:<rev2> --output-diff

What is the expected output? What do you see instead?
post-review fails trying to query git repository about origin/master

What operating system are you using? What browser?
Linux

Please provide any additional information below.
It seems that post-review should not need to be poking around the repository looking for a merge base when given an explicit revision range. As mentioned on the mailing list, this is probably related to post-review's pre-processing 'poke the repo' functionality. Since the problem can be avoided by also adding --tracking-branch=<rev1>, perhaps this should be default behavior when specifying an explicit revision range?
david
#1 david
  • +Component-RBTools
david
#2 david
  • +NotABug